linux-kernel - Re: [RFC PATCH 03/10] sched: Forced task migration on heterogeneous systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKohpomytrzUz9YFaf59-1ZJ-XYv2mXSaQk2JXEt86wh=5X12A@mail.gmail.com>
Date:	Thu, 4 Oct 2012 11:48:35 +0530
From:	Viresh Kumar <viresh.kumar@...aro.org>
To:	morten.rasmussen@....com
Cc:	paulmck@...ux.vnet.ibm.com, pjt@...gle.com, peterz@...radead.org,
	suresh.b.siddha@...el.com, linaro-sched-sig@...ts.linaro.org,
	linaro-dev@...ts.linaro.org, linux-kernel@...r.kernel.org,
	Amit Kucheria <amit.kucheria@...aro.org>,
	Robin Randhawa <robin.randhawa@....com>, Arvind.Chauhan@....com
Subject: Re: [RFC PATCH 03/10] sched: Forced task migration on heterogeneous systems

Minor comments here :)

On 22 September 2012 00:02,  <morten.rasmussen@....com> wrote:

> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index d80de46..490f1f0 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -3744,7 +3744,6 @@ int can_migrate_task(struct task_struct *p, struct lb_env *env)
>          * 1) task is cache cold, or
>          * 2) too many balance attempts have failed.
>          */
> -

:(

>         tsk_cache_hot = task_hot(p, env->src_rq->clock_task, env->sd);
>         if (!tsk_cache_hot ||
>                 env->sd->nr_balance_failed > env->sd->cache_nice_tries) {
> @@ -5516,6 +5515,199 @@ static unsigned int hmp_down_migration(int cpu, struct sched_entity *se)
>         return 0;
>  }
>

> +static int hmp_can_migrate_task(struct task_struct *p, struct lb_env *env)
> +{

<...>

> +static int move_specific_task(struct lb_env *env, struct task_struct *pm)
> +{
> +       struct task_struct *p, *n;
> +
> +       list_for_each_entry_safe(p, n, &env->src_rq->cfs_tasks, se.group_node) {
> +       if (throttled_lb_pair(task_group(p), env->src_rq->cpu,
> +                               env->dst_cpu))
> +               continue;

Please fix indentation of above if statement.

<...>

> +#else
> +static void hmp_force_up_migration(int this_cpu) { }

inline?

--
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/