linux-kernel - Re: [PATCH] Fix bogus "callbacks suppressed" messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 5 Oct 2012 07:26:39 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Markus Trippelsdorf <markus@...ppelsdorf.de>
Cc:	Borislav Petkov <bp@...64.org>, Jiri Slaby <jslaby@...e.cz>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	LKML <linux-kernel@...r.kernel.org>,
	Joe Perches <joe@...ches.com>
Subject: Re: [PATCH] Fix bogus "callbacks suppressed" messages

On Fri, Oct 05, 2012 at 02:57:17PM +0200, Markus Trippelsdorf wrote:
> On the current git tree one sees messages such as:
>  tty_init_dev: 24 callbacks suppressed
>  tty_init_dev: 3 callbacks suppressed
> 
> To fix this we need to look at condition before calling __ratelimit in
> the WARN_RATELIMIT macro. While at it remove the superfluous
> __WARN_RATELIMIT macros.
> 
> Original patch is from Joe Perches and Jiri Slaby.
> 
> Signed-off-by: Markus Trippelsdorf <markus@...ppelsdorf.de>
> Acked-and-tested-by: Borislav Petkov <borislav.petkov@....com>
> ---
>  include/linux/ratelimit.h | 27 +++++++++------------------
>  1 file changed, 9 insertions(+), 18 deletions(-)

I don't have a problem with this patch, but I don't understand why it's
now showing up.  There haven't been any changes in the ratelimit.h area
recently that I can see, so why is this change needed now?  What is in
the tty layer that is causing this, just the fact that it's actually
being used now?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/