lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 05 Oct 2012 17:32:41 +0200 From: Igor Grinberg <grinberg@...pulab.co.il> To: Arnd Bergmann <arnd@...db.de> CC: linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, arm@...nel.org, Bjorn Helgaas <bhelgaas@...gle.com>, Krzysztof Halasa <khc@...waw.pl>, Mike Rapoport <mike@...pulab.co.il>, Haojian Zhuang <haojian.zhuang@...il.com>, Eric Miao <eric.y.miao@...il.com> Subject: Re: [PATCH 14/16] ARM: pxa: armcore: fix PCI PIO warnings On 10/05/12 16:55, Arnd Bergmann wrote: > The it8152 PCI host used on the pxa/cm_x2xx machines > uses the old-style I/O window registration. This should > eventually get converted to pci_ioremap_io() but for > now, let's cast the IT8152_IO_BASE constant to an integer > type to get rid of the warnings. > > Without this patch, building cm_x2xx_defconfig results in: > > arch/arm/common/it8152.c: In function 'it8152_pci_setup': > arch/arm/common/it8152.c:287:18: warning: assignment makes integer from pointer without a cast [enabled by default] > arch/arm/common/it8152.c:288:16: warning: assignment makes integer from pointer without a cast [enabled by default] > arch/arm/common/it8152.c:291:17: warning: assignment makes integer from pointer without a cast [enabled by default] > > Signed-off-by: Arnd Bergmann <arnd@...db.de> > Cc: Bjorn Helgaas <bhelgaas@...gle.com> > Cc: Krzysztof Halasa <khc@...waw.pl> > Cc: Mike Rapoport <mike@...pulab.co.il> > Cc: Igor Grinberg <grinberg@...pulab.co.il> > Cc: Haojian Zhuang <haojian.zhuang@...il.com> > Cc: Eric Miao <eric.y.miao@...il.com> Acked-by: Igor Grinberg <grinberg@...pulab.co.il> Thanks! > --- > arch/arm/common/it8152.c | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/common/it8152.c b/arch/arm/common/it8152.c > index c4110d1..001f491 100644 > --- a/arch/arm/common/it8152.c > +++ b/arch/arm/common/it8152.c > @@ -284,11 +284,17 @@ int dma_set_coherent_mask(struct device *dev, u64 mask) > > int __init it8152_pci_setup(int nr, struct pci_sys_data *sys) > { > - it8152_io.start = IT8152_IO_BASE + 0x12000; > - it8152_io.end = IT8152_IO_BASE + 0x12000 + 0x100000; > + /* > + * FIXME: use pci_ioremap_io to remap the IO space here and > + * move over to the generic io.h implementation. > + * This requires solving the same problem for PXA PCMCIA > + * support. > + */ > + it8152_io.start = (unsigned long)IT8152_IO_BASE + 0x12000; > + it8152_io.end = (unsigned long)IT8152_IO_BASE + 0x12000 + 0x100000; > > sys->mem_offset = 0x10000000; > - sys->io_offset = IT8152_IO_BASE; > + sys->io_offset = (unsigned long)IT8152_IO_BASE; > > if (request_resource(&ioport_resource, &it8152_io)) { > printk(KERN_ERR "PCI: unable to allocate IO region\n"); -- Regards, Igor. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists