[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <1349451425.21172.119.camel@edumazet-glaptop>
Date: Fri, 05 Oct 2012 17:37:05 +0200
From: Eric Dumazet <eric.dumazet@...il.com>
To: mbizon@...ebox.fr
Cc: David Madore <david+ml@...ore.org>,
Francois Romieu <romieu@...zoreil.com>, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, Hugh Dickins <hughd@...gle.com>
Subject: Re: kernel 3.2.27 on arm: WARNING: at mm/page_alloc.c:2109
__alloc_pages_nodemask+0x1d4/0x68c()
On Fri, 2012-10-05 at 17:15 +0200, Maxime Bizon wrote:
> You think removing skb_recycle() is too big a change for stable ?
>
> Driver change is simple, as recycling is not guaranteed today you have
> this:
>
> if (!try_recycle(skb))
> skb = alloc_skb()
> >
> we just remove the try_recycle part, we are not adding any new code
> path.
>
>
> I'm not the right person to give you a correct NET_SKB_PAD value, I have
> a lot of out of tree patches in my kernels, some custom drivers as well
> that needs quite a lot of headroom, and uncommon network setup.
>
OK, I'll send the patch to remove skb_recycle()
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists