linux-kernel - Re: [PATCH 16/16] f2fs: update Kconfig and Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 5 Oct 2012 09:53:41 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	김재극 <jaegeuk.kim@...sung.com>
Cc:	viro@...iv.linux.org.uk, 'Theodore Ts'o' <tytso@....edu>,
	linux-kernel@...r.kernel.org, chur.lee@...sung.com,
	cm224.lee@...sung.com, jooyoung.hwang@...sung.com
Subject: Re: [PATCH 16/16] f2fs: update Kconfig and Makefile

On Fri, Oct 05, 2012 at 09:06:09PM +0900, 김재극 wrote:
> This adds Makefile and Kconfig for f2fs, and updates Makefile and Kconfig files
> in the fs directory.

I found it easier to comment about this here, instead of where the code
implemented this, as you describe it well here:

> +config F2FS_STAT_FS
> +	bool "F2FS Status Information"
> +	depends on F2FS_FS
> +	default y
> +	help
> +	  /proc/fs/f2fs/ contains information about partitions mounted as f2fs.
> +	  For each partition, a corresponding directory, named as its device
> +	  name, is provided with the following proc entries.
> +
> +	  f2fs_stat	major file system information managed by f2fs currently
> +	  f2fs_sit_stat	average SIT information about whole segments
> +	  f2fs_mem_stat	current memory footprint consumed by f2fs
> +
> +	  e.g., in /proc/fs/f2fs/sdb1/

As this is primarily debugging information, why not just always enable
it, and put in debugfs instead of in procfs?  That's where new debugging
information should be going.  Side benefit, your code should shrink a
bit if you use debugfs instead of procfs :)

Or, if this is really needed by all users, what is wrong with
/sys/fs/f2fs/ instead?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/