linux-kernel - Re: [PATCHv2.5] trace: reuse kbasename() functionality

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 5 Oct 2012 20:02:36 +0300
From:	Andy Shevchenko <andy.shevchenko@...il.com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Joe Perches <joe@...ches.com>,
	Frederic Weisbecker <fweisbec@...il.com>
Subject: Re: [PATCHv2.5] trace: reuse kbasename() functionality

On Fri, Oct 5, 2012 at 7:49 PM, Steven Rostedt <rostedt@...dmis.org> wrote:
> On Wed, 2012-10-03 at 11:53 +0300, Andy Shevchenko wrote:
>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
>> Cc: Steven Rostedt <rostedt@...dmis.org>
>> Cc: Frederic Weisbecker <fweisbec@...il.com>
>> ---
>>  kernel/trace/trace_uprobe.c |    8 ++++----
>>  1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
>> index 03003cd..c7ba4f6 100644
>> --- a/kernel/trace/trace_uprobe.c
>> +++ b/kernel/trace/trace_uprobe.c
>> @@ -22,6 +22,7 @@
>>  #include <linux/uaccess.h>
>>  #include <linux/uprobes.h>
>>  #include <linux/namei.h>
>> +#include <linux/string.h>
>>
>>  #include "trace_probe.h"
>>
>> @@ -263,16 +264,15 @@ static int create_trace_uprobe(int argc, char **argv)
>>
>>       /* setup a probe */
>>       if (!event) {
>> -             char *tail = strrchr(filename, '/');
>> +             char *tail;
>>               char *ptr;
>>
>> -             ptr = kstrdup((tail ? tail + 1 : filename), GFP_KERNEL);
>> -             if (!ptr) {
>> +             tail = kstrdup(kbasename(filename), GFP_KERNEL);
>
> I don't see kbasename() anywhere. Is this based off of other patches?
It's introduced by first patch in the series.

-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/