linux-kernel - Re: Seems like "sched: Add missing call to calc_load_exit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121005171007.GC15867@elie.Belkin>
Date:	Fri, 5 Oct 2012 10:10:07 -0700
From:	Jonathan Nieder <jrnieder@...il.com>
To:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Huacai Chen <chenhc@...ote.com>,
	Charles Wang <muming.wq@...bao.com>,
	Ingo Molnar <mingo@...nel.org>, stable@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: Seems like "sched: Add missing call to calc_load_exit_idle()"
 should be reverted in 3.5 branch

Peter Zijlstra wrote:
> On Thu, 2012-10-04 at 15:27 -0700, Greg Kroah-Hartman wrote:

>> I'm puzzled as well.  Any ideas if I should do anything here or not?
>
> So I think the current v3.5.5 code is fine.

Now I'm puzzled.  You wrote:

| However, since we don't restart the tick, we won't be sampling load muck
| and calling calc_load_exit_idle() from there is bound to confuse state.

Doesn't that mean 900404e5d201 "sched: Add missing call to
calc_load_exit_idle()" which is part of 3.5.5 was problematic?  Or
did I just miscount the number of "not"s?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/