linux-kernel - Re: [PATCH 13/32 v2] USB: ohci: move ohci_pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 5 Oct 2012 13:56:45 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Florian Fainelli <florian@...nwrt.org>
cc:	linux-usb@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 13/32 v2] USB: ohci: move ohci_pci_{suspend,resume} to
 ohci-hcd.c

On Fri, 5 Oct 2012, Florian Fainelli wrote:

> As suggested by Alan Stern, move the ohci-pci.c ohci_pci_{suspend,resume}
> routines to ohci-hcd.c. Due to their move, also rename them to
> ohci_{suspend,resume} to make it clear they operate on ohci_hcd. Since they
> are not necessarily called, annotate them with __maybe_unused.
> 
> Signed-off-by: Florian Fainelli <florian@...nwrt.org>
> ---
> Changes since v1:
> - moved ohci_{suspend,resume} out of the #ifdef CONFIG_PM block
> - removed the empty CONFIG_PM #ifdef/endif block in ohci-pci.c

Sorry, I didn't explain very well before.  These two routines _should_
remain within "#ifdef CONFIG_PM".

In the v1 patch you put them instead inside "#if defined(CONFIG_PM) ||
defined(CONFIG_PCI)"; that's what I didn't like.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/