linux-kernel - Re: [PATCH] ARM: Push selects for TWD/SCU into machine entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <506E8157.5030801@ti.com>
Date:	Fri, 5 Oct 2012 12:12:31 +0530
From:	Santosh Shilimkar <santosh.shilimkar@...com>
To:	Simon Horman <horms@...ge.net.au>
CC:	Stephen Boyd <sboyd@...eaurora.org>,
	Kukjin Kim <kgene.kim@...sung.com>,
	Russell King <linux@....linux.org.uk>,
	Pawel Moll <pawel.moll@....com>,
	Srinidhi Kasagar <srinidhi.kasagar@...ricsson.com>,
	Tony Lindgren <tony@...mide.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	Stephen Warren <swarren@...dotorg.org>,
	<linux-kernel@...r.kernel.org>,
	Rob Herring <rob.herring@...xeda.com>,
	Shiraz Hashim <shiraz.hashim@...com>,
	Viresh Kumar <viresh.linux@...il.com>,
	Sascha Hauer <kernel@...gutronix.de>,
	David Brown <davidb@...eaurora.org>,
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] ARM: Push selects for TWD/SCU into machine entries

On Friday 05 October 2012 06:42 AM, Simon Horman wrote:
> On Thu, Oct 04, 2012 at 02:41:46PM +0530, Santosh Shilimkar wrote:
>> On Thursday 04 October 2012 02:20 PM, Stephen Boyd wrote:
>>> The TWD and SCU configs are selected by default as long as
>>> SCORPIONMP is false and/or MCT is false. Implementing the logic
>>> this way certainly saves lines in the Kconfig but it precludes
>>> those machines which select SCORPIONMP or MCT from participating
>>> in the single zImage effort because when those machines are
>>> combined with other SMP capable machines the TWD and SCU are no
>>> longer selected.
>>>
>>> Push the select out to the machine entries so that we can compile
>>> these machines together and still select the appropriate configs.
>>>
>>> Signed-off-by: Stephen Boyd<sboyd@...eaurora.org>
>>> Cc: David Brown<davidb@...eaurora.org>
>>> Cc: Kukjin Kim<kgene.kim@...sung.com>
>>> Cc: Linus Walleij<linus.walleij@...aro.org>
>>> Cc: Pawel Moll<pawel.moll@....com>
>>> Cc: Rob Herring<rob.herring@...xeda.com>
>>> Cc: Russell King<linux@....linux.org.uk>
>>> Cc: Sascha Hauer<kernel@...gutronix.de>
>>> Cc: Shiraz Hashim<shiraz.hashim@...com>
>>> Cc: Simon Horman<horms@...ge.net.au>
>>> Cc: Srinidhi Kasagar<srinidhi.kasagar@...ricsson.com>
>>> Cc: Stephen Warren<swarren@...dotorg.org>
>>> Cc: Tony Lindgren<tony@...mide.com>
>>> Cc: Viresh Kumar<viresh.linux@...il.com>
>>> ---
>>>
>>> Does OMAP5 need to select TWD? I suspect not if it uses the
>>> architected timers.
>>>
>> Nope. OMAP5 don't use TWD. Infact the external SCU is also used
>> for A9 SOCs. You might want to check other A15 SOCS for SCU as
>> well.
>
> In that case I am a bit confused by the following result:
>
> # git checkout v3.6
> # ARCH=arm make omap2plus_defconfig
> # grep '(SOC_OMAP5|_SCU|_TWD|CONFIG_SMP|CONFIG_LOCAL_TIMERS)=' .config
> CONFIG_SOC_OMAP5=y
> CONFIG_SMP=y
> CONFIG_HAVE_ARM_SCU=y
> CONFIG_HAVE_ARM_TWD=y
> CONFIG_LOCAL_TIMERS=y

Thats because omap2plus_defconfig build all the OMAP machines together
including OMAP4 and OMAP5.

Regards
Santosh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/