linux-kernel - Re: [PATCH] drivers/tty: Folding Android's keyreset driver in sysRQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121005195303.6e652997@pyramind.ukuu.org.uk>
Date:	Fri, 5 Oct 2012 19:53:03 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	mathieu.poirier@...aro.org, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org, rdunlap@...otime.net,
	arve@...roid.com, kernel-team@...roid.com, john.stultz@...aro.org
Subject: Re: [PATCH] drivers/tty: Folding Android's keyreset driver in sysRQ

> I have the same objection as before: using platform device solely for
> the purpose of passing some data from board code to the driver. Surely
> there are other ways of passing this bit of data... What about, for
> example, making it an empty weak symbol so that board code could
> override it with strong one?

I have the same objection to it being passed in other weird ways. This is
cross architecture, cross device stuff. Magic architecture goo and weak
symbols are not the right solution.

The reset switch is a device, physically and logically.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/