linux-kernel - Re: [PATCH 19/20] drivers/net/ethernet/marvell/skge.c: fix error return code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121005080203.GX4587@mwanda>
Date:	Fri, 5 Oct 2012 11:02:03 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Julia Lawall <julia.lawall@...6.fr>,
	David Miller <davem@...emloft.net>, peter.senna@...il.com,
	shemminger@...tta.com, mlindner@...vell.com,
	kernel-janitors@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 19/20] drivers/net/ethernet/marvell/skge.c: fix error
 return code

On Fri, Oct 05, 2012 at 12:36:35AM -0700, Joe Perches wrote:
> On Fri, 2012-10-05 at 07:22 +0200, Julia Lawall wrote:
> > A tool was used to find a potential problem, and then Peter
> > studied the code to see what fix was appropriate.
> 
> Hi Julia.
> 
> Was it true that a static analysis tool found the original
> potential issue?  If so, what tool was it?
> 
> But wasn't the scripted fix applied to the rest of the tree
> robotically?

It was coccinelle.  It just prints a warning.  You have to go in
manually, review the code and pick the correct error code.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/