linux-kernel - Re: [RFC PATCH 02/06] input/rmi4: Core files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHdPZaOTwAvuhLj6wmUaFnx9CxjwZNM0QEFzu2p+jaC7jAdAig@mail.gmail.com>
Date:	Sat, 6 Oct 2012 09:06:16 -0400
From:	"devendra.aaru" <devendra.aaru@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Christopher Heiny <cheiny@...aptics.com>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Jean Delvare <khali@...ux-fr.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	Linux Input <linux-input@...r.kernel.org>,
	Allie Xiong <axiong@...aptics.com>,
	Vivian Ly <vly@...aptics.com>,
	Daniel Rosenberg <daniel.rosenberg@...aptics.com>,
	Alexandra Chen <alexandra.chen@...synaptics.com>,
	Joerie de Gram <j.de.gram@...il.com>,
	Wolfram Sang <w.sang@...gutronix.de>,
	Mathieu Poirier <mathieu.poirier@...aro.org>,
	Linus Walleij <linus.walleij@...ricsson.com>,
	Naveen Kumar Gaddipati <naveen.gaddipati@...ricsson.com>
Subject: Re: [RFC PATCH 02/06] input/rmi4: Core files

On Sat, Oct 6, 2012 at 8:19 AM, Joe Perches <joe@...ches.com> wrote:
> On Fri, 2012-10-05 at 21:09 -0700, Christopher Heiny wrote:
> []
>
> Just some trivial comments:
>
>> diff --git a/drivers/input/rmi4/rmi_driver.c b/drivers/input/rmi4/rmi_driver.c
> []
>> @@ -0,0 +1,1529 @@
> []
>> +static ssize_t delay_write(struct file *filp, const char __user *buffer,
>> +                        size_t size, loff_t *offset) {
>> +     struct driver_debugfs_data *data = filp->private_data;
>> +     struct rmi_device_platform_data *pdata =
>> +                     data->rmi_dev->phys->dev->platform_data;
>> +     int retval;
>> +     char local_buf[size];
>> +     unsigned int new_read_delay;
>> +     unsigned int new_write_delay;
>> +     unsigned int new_block_delay;
>> +     unsigned int new_pre_delay;
>> +     unsigned int new_post_delay;
>> +
>> +     retval = copy_from_user(local_buf, buffer, size);
>> +     if (retval)
>> +             return -EFAULT;
>> +
>> +     retval = sscanf(local_buf, "%u %u %u %u %u", &new_read_delay,
>> +                     &new_write_delay, &new_block_delay,
>> +                     &new_pre_delay, &new_post_delay);
>> +     if (retval != 5) {
>> +             dev_err(&data->rmi_dev->dev,
>> +                     "Incorrect number of values provided for delay.");
>> +             return -EINVAL;
>> +     }
>> +     if (new_read_delay < 0) {
>
> These are unnecessary tests as unsigned values are never < 0.
>

Nope.

1 main()
  2 {
  3         char buf[100] = "1 -2";
  4         int t, t2;
  5
  6         sscanf(buf, "%u %u", &t, &t2);
  7
  8         if (t > 0) {
  9                 printf("greater\n");
 10         }
 11
 12         if (t2 > 0) {
 13                 printf("greater\n");
 14         } else {
 15                 printf("lesser\n");
 16         }
 17 }


Thanks,
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/