linux-kernel - Re: [PATCH 3/4] uprobes: Kill set_orig_insn()->is_swbp_at

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20121006071808.GF27781@linux.vnet.ibm.com>
Date:	Sat, 6 Oct 2012 12:48:08 +0530
From:	Srikar Dronamraju <srikar@...ux.vnet.ibm.com>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	Ingo Molnar <mingo@...e.hu>, Peter Zijlstra <peterz@...radead.org>,
	Ananth N Mavinakayanahalli <ananth@...ibm.com>,
	Anton Arapov <anton@...hat.com>,
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] uprobes: Kill set_orig_insn()->is_swbp_at_addr()

* Oleg Nesterov <oleg@...hat.com> [2012-09-23 22:19:50]:

> Unlike set_swbp(), set_orig_insn()->is_swbp_at_addr() makes sense,
> although it can't prevent all confusions.
> 
> But the usage of is_swbp_at_addr() is equally confusing, and it adds
> the extra get_user_pages() we can avoid.
> 
> This patch removes set_orig_insn()->is_swbp_at_addr() but changes
> write_opcode() to do the necessary checks before replace_page().
> 
> Perhaps it also makes sense to ensure PAGE_MAPPING_ANON in unregister
> case.
> 
> find_active_uprobe() becomes the only user of is_swbp_at_addr(),
> we can change its semantics.
> 
> Signed-off-by: Oleg Nesterov <oleg@...hat.com>
> ---



Acked-by: Srikar Dronamraju <srikar@...ux.vnet.ibm.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/