linux-kernel - Re: virtio build breakage.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87d30wyry0.fsf@rustcorp.com.au>
Date:	Sat, 06 Oct 2012 17:04:31 +0930
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Dave Jones <davej@...hat.com>
Cc:	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: virtio build breakage.

Dave Jones <davej@...hat.com> writes:

> After linking, I see this..
>
> ERROR: "virtqueue_kick" [net/9p/9pnet_virtio.ko] undefined!
> ERROR: "virtqueue_get_buf" [net/9p/9pnet_virtio.ko] undefined!

Cool!

Someone else spotted this recently, and the fix is in my recent pull
request to Linus:

commit 04679f34c141a0591e525d392929efc249440a7c
Author: Michael S. Tsirkin <mst@...hat.com>
Date:   Fri Sep 28 15:05:14 2012 +0930

    virtio-balloon: dependency fix
    
    Devices should depend on virtio, not select it.  It's supposed to be
    selected by the particular driver, e.g. VIRTIO_PCI.
    Make balloon depend on VIRTIO and EXPERIMENTAL
    (to match description).
    
    Signed-off-by: Michael S. Tsirkin <mst@...hat.com>
    Signed-off-by: Rusty Russell <rusty@...tcorp.com.au>

diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
index f38b17a..271be80 100644
--- a/drivers/virtio/Kconfig
+++ b/drivers/virtio/Kconfig
@@ -27,8 +27,7 @@ config VIRTIO_PCI
 
 config VIRTIO_BALLOON
 	tristate "Virtio balloon driver (EXPERIMENTAL)"
-	select VIRTIO
-	select VIRTIO_RING
+	depends on EXPERIMENTAL && VIRTIO
 	---help---
 	 This driver supports increasing and decreasing the amount
 	 of memory within a KVM guest.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/