linux-kernel - Re: [ 29/52] xHCI: add aborting command ring function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1349571728.16173.80.camel@deadeye.wl.decadent.org.uk>
Date:	Sun, 07 Oct 2012 02:02:08 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Sarah Sharp <sarah.a.sharp@...ux.intel.com>
Cc:	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	alan@...rguk.ukuu.org.uk, Elric Fu <elricfu1@...il.com>,
	Miroslav Sabljic <miroslav.sabljic@....com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [ 29/52] xHCI: add aborting command ring function

On Thu, 2012-10-04 at 14:21 -0700, Greg Kroah-Hartman wrote:
[...]
> --- a/drivers/usb/host/xhci.c
> +++ b/drivers/usb/host/xhci.c
> @@ -52,7 +52,7 @@ MODULE_PARM_DESC(link_quirk, "Don't clea
>   * handshake done).  There are two failure modes:  "usec" have passed (major
>   * hardware flakeout), or the register reads as all-ones (hardware removed).
>   */
> -static int handshake(struct xhci_hcd *xhci, void __iomem *ptr,
> +int handshake(struct xhci_hcd *xhci, void __iomem *ptr,
>  		      u32 mask, u32 done, int usec)
>  {
>  	u32	result;
[...]

I don't think it matters for stable, but since this function is now
extern it should have an 'xhci_' prefix.

Ben.

-- 
Ben Hutchings
You can't have everything.  Where would you put it?

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)