linux-kernel - Re: [bisected] stray angle bracket in dmesg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121008141829.GA244@x4>
Date:	Mon, 8 Oct 2012 16:18:29 +0200
From:	Markus Trippelsdorf <markus@...ppelsdorf.de>
To:	"Wouter M. Koolen" <W.M.Koolen-Wijkstra@....nl>
Cc:	lkml <linux-kernel@...r.kernel.org>, jim.cromie@...il.com,
	torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
	jbaron@...hat.com, Greg KH <gregkh@...uxfoundation.org>
Subject: Re: [bisected] stray angle bracket in dmesg

On 2012.10.08 at 15:05 +0100, Wouter M. Koolen wrote:
> Hi guys,
> 
> After upgrading from 3.5.4 to 3.5.5 I started noticing log lines of the 
> form (just a random sample)
> 
> pci_bus 0000:00: >resource 4 [io  0x0000-0x0cf7]
> pnp 00:07: >Plug and Play ACPI device, IDs PNP0303 (active)
> system 00:04: >[io  0x0680-0x069f] has been reserved
> pci_root PNP0A08:00: >host bridge window [io  0x0000-0x0cf7]
> 
> Note the right angle bracket between the device name and the message 
> string. These angle brackets were not there up till 3.5.4.
> 
> This does not happen in all dmesg lines. Only the ones that start with a 
> device identifier.
> 
> I assume this angle bracket was not intentional. Otherwise please excuse 
> the noise.
> 
> I noticed this because all of these lines now suddenly slip through my 
> logcheck ignore rules.
> 
> Bisection points to this commit:
> 
> commit 3d822616ca81881d8c19d0b473e79ba241c700de
> Author: Markus Trippelsdorf <markus@...ppelsdorf.de>
> Date:   Sat Aug 18 18:35:51 2012 -0600

This patch should be reverted for stable, since the move to ASCII SOH (
commit 04d2c8c83d0) wasn't backported. So the fix just isn't necessary.

-- 
Markus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/