linux-kernel - Re: [PATCH 10/16] f2fs: add core inode operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon, 08 Oct 2012 09:35:08 -0700
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Changman Lee <cm224.lee@...il.com>
Cc:	김재극 <jaegeuk.kim@...sung.com>,
	"Theodore Ts'o" <tytso@....edu>, gregkh@...uxfoundation.org,
	linux-kernel@...r.kernel.org, jooyoung.hwang@...sung.com,
	viro@...iv.linux.org.uk, chur.lee@...sung.com,
	cm224.lee@...sung.com
Subject: Re: [PATCH 10/16] f2fs: add core inode operations

Changman Lee <cm224.lee@...il.com> writes:
>> > +void update_inode(struct inode *inode, struct page *node_page)
>> > +{
>> > +     struct f2fs_node *rn;
>> > +     struct f2fs_inode *ri;
>> > +
>> > +     wait_on_page_writeback(node_page);
>> > +
>> > +     rn = page_address(node_page);
>> > +     ri = &(rn->i);
>> > +
>> > +     ri->i_mode = cpu_to_le16(inode->i_mode);
>> > +     ri->i_uid = cpu_to_le32(inode->i_uid);
>> > +     ri->i_gid = cpu_to_le32(inode->i_gid);
>> And make this:
>>         i_uid_write(inode, le32_to_cpu(ri->i_uid));
>>         i_gid_write(inode, le32_to_cpu(ri->i_gid));
>>
>
> You mean this. Right? :)
> ri->i_uid = cpu_to_le32(i_uid_read(inode));
> ri->i_gid = cpu_to_le32(i_gid_read(inode));

Yeah. ;)

I did have that one backwards.

Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/