[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20121008180900.GL3874@atomide.com>
Date: Mon, 8 Oct 2012 11:09:00 -0700
From: Tony Lindgren <tony@...mide.com>
To: linux-arm-kernel@...ts.infradead.org
Cc: alsa-devel@...a-project.org, linux-omap@...r.kernel.org,
Mark Brown <broonie@...nsource.wolfsonmicro.com>,
Herbert Xu <herbert@...dor.apana.org.au>,
Vinod Koul <vinod.koul@...el.com>, Dan Williams <djbw@...com>,
linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org,
Liam Girdwood <lrg@...com>,
Peter Ujfalusi <peter.ujfalusi@...com>,
Deepak Saxena <dsaxena@...xity.net>,
Chris Ball <cjb@...top.org>, Matt Mackall <mpm@...enic.com>,
Venkatraman S <svenkatr@...com>,
"David S. Miller" <davem@...emloft.net>,
Jarkko Nikula <jarkko.nikula@...mer.com>,
linux-crypto@...r.kernel.org
Subject: Re: [PATCH 1/2] ARM: OMAP: Trivial driver changes to remove
include plat/cpu.h
* Tony Lindgren <tony@...mide.com> [121008 10:37]:
> Drivers should not use cpu_is_omap or cpu_class_is_omap macros,
> they should be private to the platform init code. And we'll be
> removing plat/cpu.h and only have a private soc.h for the
> arch/arm/*omap* code.
>
> This patch is intended as preparation for the core omap changes
> and removes the need to include plat/cpu.h from several drivers.
> This is needed for the ARM common zImage support.
>
> These changes are OK to do because:
>
> - omap-rng.c and hsmmc.c don't need plat/cpu.h
>
> - omap-aes.c and omap-sham.c get the proper platform_data
> passed to them so they don't need extra checks in the driver
>
> - omap-dma.c and omap-pcm.c can test the arch locally as
> omap1 and omap2 cannot be compiled together because of
> conflicting compiler flags
> --- a/drivers/mmc/host/omap_hsmmc.c
> +++ b/drivers/mmc/host/omap_hsmmc.c
> @@ -40,7 +40,6 @@
> #include <linux/pm_runtime.h>
> #include <linux/platform_data/mmc-omap.h>
> #include <mach/hardware.h>
> -#include <plat/cpu.h>
>
> /* OMAP HSMMC Host Controller Registers */
> #define OMAP_HSMMC_SYSSTATUS 0x0014
Actually I'll fold this mmc change into an earlier patch
I've posted as "ARM: OMAP: Split plat/mmc.h into local headers
and platform_data".
Regards,
Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists