linux-kernel - Re: [ 29/52] xHCI: add aborting command ring function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20121008204844.GH18378@xanatos>
Date:	Mon, 8 Oct 2012 13:48:44 -0700
From:	Sarah Sharp <sarah.a.sharp@...ux.intel.com>
To:	Ben Hutchings <ben@...adent.org.uk>
Cc:	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	alan@...rguk.ukuu.org.uk, Elric Fu <elricfu1@...il.com>,
	Miroslav Sabljic <miroslav.sabljic@....com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [ 29/52] xHCI: add aborting command ring function

On Sun, Oct 07, 2012 at 02:02:08AM +0100, Ben Hutchings wrote:
> On Thu, 2012-10-04 at 14:21 -0700, Greg Kroah-Hartman wrote:
> [...]
> > --- a/drivers/usb/host/xhci.c
> > +++ b/drivers/usb/host/xhci.c
> > @@ -52,7 +52,7 @@ MODULE_PARM_DESC(link_quirk, "Don't clea
> >   * handshake done).  There are two failure modes:  "usec" have passed (major
> >   * hardware flakeout), or the register reads as all-ones (hardware removed).
> >   */
> > -static int handshake(struct xhci_hcd *xhci, void __iomem *ptr,
> > +int handshake(struct xhci_hcd *xhci, void __iomem *ptr,
> >  		      u32 mask, u32 done, int usec)
> >  {
> >  	u32	result;
> [...]
> 
> I don't think it matters for stable, but since this function is now
> extern it should have an 'xhci_' prefix.

Is it a non-issue?  I know several other drivers have a handshake
function, including the EHCI driver.  If both xHCI and EHCI is built-in,
will the EHCI driver compile?  I'll have to double check this...

Thanks for catching this!

Sarah Sharp
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/