linux-kernel - RE: [PATCH 3/5] mfd: tps65090: remove unused member of struct tps65090

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 8 Oct 2012 11:10:40 +0530
From:	Venu Byravarasu <vbyravarasu@...dia.com>
To:	Laxman Dewangan <ldewangan@...dia.com>,
	"sameo@...ux.intel.com" <sameo@...ux.intel.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 3/5] mfd: tps65090: remove unused member of struct
 tps65090

> -----Original Message-----
> From: Laxman Dewangan
> Sent: Sunday, October 07, 2012 8:52 PM
> To: sameo@...ux.intel.com
> Cc: linux-kernel@...r.kernel.org; Venu Byravarasu; Laxman Dewangan
> Subject: [PATCH 3/5] mfd: tps65090: remove unused member of struct
> tps65090
> 
> Remove unused member from tps65090 data structure as

Remove unused members 

> these are not used.
> 
> Signed-off-by: Laxman Dewangan <ldewangan@...dia.com>
> ---
>  drivers/mfd/tps65090.c       |    6 +-----
>  include/linux/mfd/tps65090.h |   11 -----------
>  2 files changed, 1 insertions(+), 16 deletions(-)
> 
> diff --git a/drivers/mfd/tps65090.c b/drivers/mfd/tps65090.c
> index f95f7f6..3cfc9dc 100644
> --- a/drivers/mfd/tps65090.c
> +++ b/drivers/mfd/tps65090.c
> @@ -269,12 +269,9 @@ static int __devinit tps65090_i2c_probe(struct
> i2c_client *client,
>  		return -ENOMEM;
>  	}
> 
> -	tps65090->client = client;
>  	tps65090->dev = &client->dev;
>  	i2c_set_clientdata(client, tps65090);
> 
> -	mutex_init(&tps65090->lock);
> -
>  	if (client->irq) {
>  		ret = tps65090_irq_init(tps65090, client->irq, pdata-
> >irq_base);
>  		if (ret) {
> @@ -284,8 +281,7 @@ static int __devinit tps65090_i2c_probe(struct
> i2c_client *client,
>  		}
>  	}
> 
> -	tps65090->rmap = devm_regmap_init_i2c(tps65090->client,
> -					      &tps65090_regmap_config);
> +	tps65090->rmap = devm_regmap_init_i2c(client,
> &tps65090_regmap_config);

Indentation missing.
 

>  	if (IS_ERR(tps65090->rmap)) {
>  		ret = PTR_ERR(tps65090->rmap);
>  		dev_err(&client->dev, "regmap_init failed with err: %d\n",
> ret);
> diff --git a/include/linux/mfd/tps65090.h b/include/linux/mfd/tps65090.h
> index 6bc31d8..6c57622 100644
> --- a/include/linux/mfd/tps65090.h
> +++ b/include/linux/mfd/tps65090.h
> @@ -25,26 +25,15 @@
>  #include <linux/irq.h>
> 
>  struct tps65090 {
> -	struct mutex		lock;
>  	struct device		*dev;
> -	struct i2c_client	*client;
>  	struct regmap		*rmap;
>  	struct irq_chip		irq_chip;
>  	struct mutex		irq_lock;
>  	int			irq_base;
> -	unsigned int		id;
> -};
> -
> -struct tps65090_subdev_info {
> -	int		id;
> -	const char	*name;
> -	void		*platform_data;
>  };
> 
>  struct tps65090_platform_data {
>  	int irq_base;
> -	int num_subdevs;
> -	struct tps65090_subdev_info *subdevs;
>  };
> 
>  /*
> --
> 1.7.1.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/