linux-kernel - RE: Possible regression: BUG in fs/sysfs/group.c:65

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <D0B11485C64D4B47B66902F8A4E901BE34D016@SHSMSX101.ccr.corp.intel.com>
Date:	Tue, 9 Oct 2012 05:44:22 +0000
From:	"Wei, Gang" <gang.wei@...el.com>
To:	Kent Yoder <key@...ux.vnet.ibm.com>,
	"Eric W. Biederman" <ebiederm@...ssion.com>
CC:	Ben Guthro <ben@...hro.net>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"Wei, Gang" <gang.wei@...el.com>
Subject: RE: Possible regression: BUG in fs/sysfs/group.c:65

Kent Yoder wrote on 2012-10-06:
> On Fri, Oct 05, 2012 at 11:16:06AM -0700, Eric W. Biederman wrote:
>> Ben Guthro <ben@...hro.net> writes:
>> 
>>> I am seeing a regression in today's (Oct 5) kernel - 2 WARNINGS, and a
>>> BUG below that seems to occur upon resuming from S3.
>>> 
>>> I can start a bisection with 3.6 - but wanted to check to see if
>>> anyone else is also experiencing this failure...
>> 
>> I took a quick look and this is a deterministic failure.  The same
>> file is being added to sysfs twice.
>> 
>> Since the routine causing this failure appears to be sys_add_ppi I
>> expect the commit that added this failure mode is the commit below.
>> 
>> Xiaoyan Zhang, Kent Yoder can you guys look at this see why the tpm
>> code is adding itself multiple times into sysfs?
> 
>   It looks like the ppi sysfs teardown code is MIA. Xiaoyan, can you add
> it to tpm_ppi.c, with a caller in tpm_unregister_hardware?

I will try to provide a fix.

Jimmy

Download attachment "smime.p7s" of type "application/pkcs7-signature" (8586 bytes)