linux-kernel - Re: [PATCH v2 2/6] Add the main bulk of core driver for SI476x code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121009063349.GN8237@opensource.wolfsonmicro.com>
Date:	Tue, 9 Oct 2012 15:33:53 +0900
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Andrey Smirnov <andrey.smirnov@...vergeddevices.net>
Cc:	andrey.smrinov@...vergeddevices.net, hverkuil@...all.nl,
	mchehab@...hat.com, sameo@...ux.intel.com, perex@...ex.cz,
	tiwai@...e.de, linux-media@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/6] Add the main bulk of core driver for SI476x code

On Fri, Oct 05, 2012 at 06:54:58PM -0700, Andrey Smirnov wrote:

> +			err = regulator_enable(core->supplies.va);
> +			if (err < 0)
> +				break;
> +			
> +			err = regulator_enable(core->supplies.vio2);
> +			if (err < 0)
> +				goto disable_va;
> +
> +			err = regulator_enable(core->supplies.vd);
> +			if (err < 0)
> +				goto disable_vio2;
> +			
> +			err = regulator_enable(core->supplies.vio1);
> +			if (err < 0)
> +				goto disable_vd;

If the sequencing is critical here you should have comments explaining
what the requirement is, otherwise this looks like a prime candidate
for conversion to regulator_bulk_enable() (and similarly for all the
other regulator usage, it appears that all the regulators are worked
with in a bulk fashion).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/