linux-kernel - Re: [PATCH 1/3] mfd: Convert tps6586x to irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5073BE7F.5060107@nvidia.com>
Date:	Tue, 9 Oct 2012 11:34:47 +0530
From:	Laxman Dewangan <ldewangan@...dia.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
CC:	"sameo@...ux.intel.com" <sameo@...ux.intel.com>,
	"grant.likely@...retlab.ca" <grant.likely@...retlab.ca>,
	"linus.walleij@...aro.org" <linus.walleij@...aro.org>,
	Stephen Warren <swarren@...dia.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] mfd: Convert tps6586x to irq_domain

On Tuesday 09 October 2012 11:53 AM, Mark Brown wrote:
> On Tue, Oct 09, 2012 at 11:18:24AM +0530, Laxman Dewangan wrote:
>> On Tuesday 09 October 2012 11:36 AM, Mark Brown wrote:
>>> but can you convert to regmap_irq?
>> Yes, the motivation was this when I started this cleanups but found
>> that there is 4 interrupt status and 5 interrupt mask register.
>> Probably we need to pass the number of interrupt status and
>> interrupt mask register to expand the regmap-irq framework to handle
>> this case also. If it is fine then I can work towards that.
> Can you explain in more detail - I guess there's a different mapping of
> the bits into the registers for mask and status (in which case the
> generic code just won't work anyway).
The bit definitions are also different in status and mask register and 
yes, this will be again problem as we do in isr thread
  data->status_buf[i] &= ~data->mask_buf[i];

So given the constraint, generic will not work here.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/