linux-kernel - Re: [PATCH 1/1] Drivers: scsi: storvsc: Account for in-transit packets in the RESET path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1349782700.2615.65.camel@dabdike.int.hansenpartnership.com>
Date:	Tue, 09 Oct 2012 12:38:20 +0100
From:	James Bottomley <James.Bottomley@...senPartnership.com>
To:	KY Srinivasan <kys@...rosoft.com>
Cc:	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
	"ohering@...e.com" <ohering@...e.com>,
	"hch@...radead.org" <hch@...radead.org>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: Re: [PATCH 1/1] Drivers: scsi: storvsc: Account for in-transit
 packets in the RESET path

On Mon, 2012-10-08 at 15:51 +0000, KY Srinivasan wrote:
> 
> > -----Original Message-----
> > From: K. Y. Srinivasan [mailto:kys@...rosoft.com]
> > Sent: Tuesday, October 02, 2012 2:04 PM
> > To: gregkh@...uxfoundation.org; linux-kernel@...r.kernel.org;
> > devel@...uxdriverproject.org; ohering@...e.com; jbottomley@...allels.com;
> > hch@...radead.org; linux-scsi@...r.kernel.org
> > Cc: KY Srinivasan; stable@...r.kernel.org
> > Subject: [PATCH 1/1] Drivers: scsi: storvsc: Account for in-transit packets in the
> > RESET path
> > 
> > Properly account for I/O in transit before returning from the RESET call.
> > In the absense of this patch, we could have a situation where the host may
> > respond to a command that was issued prior to the issuance of the RESET
> > command at some arbitrary time after responding to the RESET command.
> > Currently, the host does not do anything with the RESET command.
> > 
> > Signed-off-by: K. Y. Srinivasan <kys@...rosoft.com>
> > Cc: stable@...r.kernel.org
> > ---
> >  drivers/scsi/storvsc_drv.c |    5 +++++
> >  1 files changed, 5 insertions(+), 0 deletions(-)
> > 
> > diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
> > index 528d52b..0144078 100644
> > --- a/drivers/scsi/storvsc_drv.c
> > +++ b/drivers/scsi/storvsc_drv.c
> > @@ -1221,7 +1221,12 @@ static int storvsc_host_reset_handler(struct scsi_cmnd
> > *scmnd)
> >  	/*
> >  	 * At this point, all outstanding requests in the adapter
> >  	 * should have been flushed out and return to us
> > +	 * There is a potential race here where the host may be in
> > +	 * the process of responding when we return from here.
> > +	 * Just wait for all in-transit packets to be accounted for
> > +	 * before we return from here.
> >  	 */
> > +	storvsc_wait_to_drain(stor_device);
> > 
> >  	return SUCCESS;
> >  }
> > --
> > 1.7.4.1
> 
> James,
> 
> This patch is critical for running Linux based workloads on our Cloud infrastructure - Azure.
> Please let me know if there are any issues.

So just for next time: it's a bit hard to work out this is a critical
issue from the change log.  If I had to guess, I'd say the response to a
command killed by reset causes some type of use after free and a
potential oops (all of which would have been very nice in the change
log)?

James
        

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/