linux-kernel - Re: [PATCH] Staging: winbond: wbusb: Fixed coding style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1349799738.2386.1.camel@joe-AO722>
Date:	Tue, 09 Oct 2012 09:22:18 -0700
From:	Joe Perches <joe@...ches.com>
To:	Adil Mujeeb <mujeeb.adil@...il.com>
Cc:	pavel@....cz, gregkh@...uxfoundation.org,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: winbond: wbusb: Fixed coding style issue

On Tue, 2012-10-09 at 21:40 +0530, Adil Mujeeb wrote:
> Repalces printk's with pr_debug
[]
> diff --git a/linux-3.6-rc7/drivers/staging/winbond/wbusb.c b/linux-3.6-rc7/drivers/staging/winbond/wbusb.c
> index 0ca857a..48fe622 100644
> --- a/linux-3.6-rc7/drivers/staging/winbond/wbusb.c
> +++ b/linux-3.6-rc7/drivers/staging/winbond/wbusb.c
> @@ -79,18 +79,18 @@ static int wbsoft_add_interface(struct ieee80211_hw *dev,
>  static void wbsoft_remove_interface(struct ieee80211_hw *dev,
>  				    struct ieee80211_vif *vif)
>  {
> -	printk("wbsoft_remove interface called\n");
> +	pr_debug("wbsoft_remove interface called\n");

It'd be more consistent to use
	pr_debug("%s called\n", __func__);
everywhere.

It might be even nicer to remove almost all of these.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/