linux-kernel - Re: [PATCH] [RFC] pidns: don't zap processes several times

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20121009175011.GA10492@redhat.com>
Date:	Tue, 9 Oct 2012 19:50:11 +0200
From:	Oleg Nesterov <oleg@...hat.com>
To:	Andrey Wagin <avagin@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Serge Hallyn <serge.hallyn@...onical.com>,
	Paul Gortmaker <paul.gortmaker@...driver.com>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Vasiliy Kulikov <segoon@...nwall.com>,
	Cyrill Gorcunov <gorcunov@...nvz.org>,
	Pavel Emelyanov <xemul@...allels.com>
Subject: Re: [PATCH] [RFC] pidns: don't zap processes several times

On 10/09, Andrey Wagin wrote:
>
> 2012/10/9 Oleg Nesterov <oleg@...hat.com>:
> > Hmm. This is off-topic, but...
> >
> >         create_pid_namespace:
> >
> >                 unsigned int level = parent_pid_ns->level + 1;
> >                 ns->pid_cachep = create_pid_cachep(level + 1);
>
> Yes, it's correct, because pid->numbers[ns->level] should be valid, so
>  a size of an array pid->numbers should be (level + 1).

Ah, yes. I missed that ns->level is "last index", not "array size".
Indeed, init_pid_ns.level = 0.

Thanks Andrey.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/