linux-kernel - Re: [PATCH] pch_gbe: Fix build error by selecting all the possible dependencies.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20121009.135119.392429282974593732.davem@davemloft.net>
Date:	Tue, 09 Oct 2012 13:51:19 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	haicheng.lee@...il.com
Cc:	haicheng.li@...ux.intel.com, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, fengguang.wu@...el.com
Subject: Re: [PATCH] pch_gbe: Fix build error by selecting all the possible
 dependencies.

From: Haicheng Li <haicheng.lee@...il.com>
Date: Tue,  9 Oct 2012 17:43:12 +0800

> Fengguang reported a kernel build failure as following:
> drivers/built-in.o: In function `pch_gbe_ioctl':
> pch_gbe_main.c:(.text+0x510370): undefined reference to `pch_ch_control_write'
> pch_gbe_main.c:(.text+0x510393): undefined reference to `pch_ch_control_write'
> pch_gbe_main.c:(.text+0x5103b3): undefined reference to `pch_ch_control_write'
> ...
> 
> It's a regression by commit da1586461. The root cause is that
> the CONFIG_PPS is not set there, consequently CONFIG_PTP_1588_CLOCK
> can not be set anyway, which finally causes ptp_pch and pch_gbe_main
> build failures.
> 
> As David prefers to use *select* to fix such module co-dependency issues,
> this patch explicitly selects all the possible dependencies of PCH_PTP.
> 
> Reported-by: Fengguang Wu <fengguang.wu@...el.com>
> Reviewed-by: David S. Miller <davem@...emloft.net>
> Signed-off-by: Haicheng Li <haicheng.lee@...il.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/