linux-kernel - Re: [PATCH] Do not use cpu_to_node() to find an offlined cpu's node.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1210091617260.10143@chino.kir.corp.google.com>
Date:	Tue, 9 Oct 2012 16:27:01 -0700 (PDT)
From:	David Rientjes <rientjes@...gle.com>
To:	Peter Zijlstra <peterz@...radead.org>
cc:	Tang Chen <tangchen@...fujitsu.com>, mingo@...hat.com,
	miaox@...fujitsu.com, wency@...fujitsu.com,
	linux-kernel@...r.kernel.org, linux-numa@...r.kernel.org
Subject: Re: [PATCH] Do not use cpu_to_node() to find an offlined cpu's
 node.

On Tue, 9 Oct 2012, Peter Zijlstra wrote:

> Well the code they were patching is in the wakeup path. As I think Tang
> said, we leave !runnable tasks on whatever cpu they ran on last, even if
> that cpu is offlined, we try and fix up state when we get a wakeup.
> 
> On wakeup, it tries to find a cpu to run on and will try a cpu of the
> same node first.
> 
> Now if that node's entirely gone away, it appears the cpu_to_node() map
> will not return a valid node number.
> 
> I think that's a change in behaviour, it didn't used to do that afaik.
> Certainly this code hasn't change in a while.
> 

If cpu_to_node() always returns a valid node id even if all cpus on the 
node are offline, then the cpumask_of_node() implementation, which the 
sched code is using, should either return an empty cpumask (if 
node_to_cpumask_map[nid] isn't freed) or cpu_online_mask.  The change in 
behavior here occurred because 
cpu_hotplug-unmap-cpu2node-when-the-cpu-is-hotremoved.patch in -mm doesn't 
return a valid node id and forces it to return -1 so a kzalloc_node(..., 
-1) fallsback to allocate anywhere.

But if you only need cpu_to_node() when waking up to find a runnable cpu 
for this NUMA information, then I think you can just change the 
kzalloc_node() in alloc_{fair,rt}_sched_group() to do 
kzalloc(..., cpu_online(cpu) ? cpu_to_node(cpu) : NUMA_NO_NODE).

 [ The changelog here is confusing because it's fixing a problem in 
   linux-next without saying so. ]
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/