linux-kernel - Re: [PATCH 2/4 v2] irqdomain: augment add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 10 Oct 2012 08:54:36 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Rob Herring <robherring2@...il.com>,
	Grant Likely <grant.likely@...retlab.ca>
Cc:	Linus Walleij <linus.walleij@...ricsson.com>,
	linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
	Anmar Oueja <anmar.oueja@...aro.org>,
	Paul Mundt <lethal@...ux-sh.org>,
	Russell King <linux@....linux.org.uk>,
	Lee Jones <lee.jones@...aro.org>
Subject: Re: [PATCH 2/4 v2] irqdomain: augment add_simple() to allocate descs

On Mon, Oct 1, 2012 at 2:11 PM, Rob Herring <robherring2@...il.com> wrote:
> On 10/01/2012 02:35 AM, Linus Walleij wrote:
>> From: Linus Walleij <linus.walleij@...aro.org>
>>
>> Currently we rely on all IRQ chip instances to dynamically
>> allocate their IRQ descriptors unless they use the linear
>> IRQ domain. So for irqdomain_add_legacy() and
>> irqdomain_add_simple() the caller need to make sure that
>> descriptors are allocated.
>>
>> Let's slightly augment the yet unused irqdomain_add_simple()
>> to also allocate descriptors as a means to simplify usage
>> and avoid code duplication throughout the kernel.
>>
>> We warn if descriptors cannot be allocated, e.g. if a
>> platform has the bad habit of hogging descriptors at boot
>> time.
>>
>> Cc: Rob Herring <rob.herring@...xeda.com>
>> Cc: Thomas Gleixner <tglx@...utronix.de>
>> Cc: Grant Likely <grant.likely@...retlab.ca>
>> Cc: Paul Mundt <lethal@...ux-sh.org>
>> Cc: Russell King <linux@....linux.org.uk>
>> Cc: Lee Jones <lee.jones@...aro.org>
>> Signed-off-by: Linus Walleij <linus.walleij@...aro.org>
>
> Looks good.
>
> Reviewed-by: Rob Herring <rob.herring@...xeda.com>

So what do we do with this patch? Grant?

I think the change is good to get in ASAP and since I
now have one patch in pinctrl depending on it I have
tentatively applied it there.

Nobody sent any irqdomain fixes for this merge
window, maybe this is the only relevant patch...

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/