| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 10 Oct 2012 14:35:36 +0200 From: Oliver Neukum <oneukum@...e.de> To: Constantine Shulyupin <const@...elinux.com> Cc: nsekhar@...com, gregkh@...uxfoundation.org, davinci-linux-open-source@...ux.davincidsp.com, linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org, balbi@...com, linux-arm-kernel@...ts.infradead.org Subject: Re: [PATCH v2] USB: usb-skeleton.c: fix compilation error and restore kref_put on fail in skel_open On Wednesday 10 October 2012 12:32:54 Constantine Shulyupin wrote: > From: Constantine Shulyupin <const@...eLinux.com> > > Function skel_open increments usage count for the device with kref_get and the usage count should be decremented on the function failure. > > Some last changes in function skel_open and finally commit > 52a7499 Revert "USB: usb-skeleton.c: fix open/disconnect race" > introduced a bug in function skel_open, which this patch fixes. > > -- > Changelog: > -- Fixed accordinly feedback of Oliver Neukum oneukum@...e.de: also need to drop the lock. Well, touching file->private_data is not nice. It is correct, but really dirty. The skeleton driver should be nice. Could you introduce a second label for goto at the right place? Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists