linux-kernel - Re: [PATCH] x86: Switch to vga console only if framebuffer details are missing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 10 Oct 2012 10:32:33 -0400
From:	Peter Jones <pjones@...hat.com>
To:	Matt Fleming <matt.fleming@...el.com>
Cc:	linux-kernel@...r.kernel.org, linux-efi@...r.kernel.org,
	"H. Peter Anvin" <hpa@...or.com>, Matthew Garrett <mjg@...hat.com>,
	Olof Johansson <olof@...om.net>,
	Ingo Molnar <mingo@...nel.org>,
	Alan Cox <alan@...rguk.ukuu.org.uk>
Subject: Re: [PATCH] x86: Switch to vga console only if framebuffer details
 are missing

On Wed, Oct 10, 2012 at 02:43:07PM +0100, Matt Fleming wrote:
> On Mon, 2012-09-17 at 11:29 +0100, Matt Fleming wrote:
> > From: Matt Fleming <matt.fleming@...el.com>
> > 
> > The efi_enabled variable has come to mean "Do we have EFI runtime
> > services available?". However, lack of EFI runtime services does not
> > mean that we should switch to using the VGA console. Provided that the
> > boot loader passed the dimensions of the EFI framebuffer there is no
> > reason we can't use efifb.
> > 
> > There's also no reason to check the memory type of 0xa0000 - whether
> > or not that memory region is EFI_CONVENTIONAL_MEMORY is immaterial -
> > the EFI framebuffer device will still work, and checking the EFI
> > memory type of a memory region on a non-EFI machine is illogical.
> > 
> > Cc: H. Peter Anvin <hpa@...or.com>
> > Cc: Matthew Garrett <mjg@...hat.com>
> > Cc: Olof Johansson <olof@...om.net>
> > Cc: Peter Jones <pjones@...hat.com>
> > Cc: Ingo Molnar <mingo@...nel.org>
> > Signed-off-by: Matt Fleming <matt.fleming@...el.com>
> > ---
> >  arch/x86/kernel/setup.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> Ping? Anybody got an opinion on this one?

Provided "video=vga" still works to circumvent Alan's objection, I'm all
for it.

-- 
        Peter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/