linux-kernel - Re: [PATCH v3.6.1] usb: serial: ftdi_sio: Add missing chars_in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20121010164819.01c1a1c0@pyramind.ukuu.org.uk>
Date:	Wed, 10 Oct 2012 16:48:19 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Jarkko Huijts <jarkko.huijts@...oresystems.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3.6.1] usb: serial: ftdi_sio: Add missing
 chars_in_buffer function

On Wed, 10 Oct 2012 15:05:06 +0200
Jarkko Huijts <jarkko.huijts@...oresystems.com> wrote:

> From: Jarkko Huijts <jarkko.huijts@...il.com>
> 
> The driver does not wait until the hardware buffer (for data from the PC to the
> UART line) is drained when tcdrain or close is called in an application.
> Solution: Implement a chars_in_buffer function that checks both the software
> and hardware buffer. If the TEMT (TX empty) bit of the line status register
> indicates the hw buffer is not empty, let the function return at least 1. This
> has been verified to work correctly with an FT232RL. The check on the hw buffer
> can not be done for the original SIO device.
> 
> Signed-off-by: Jarkko Huijts <jarkko.huijts@...il.com>

Acked-by: Alan Cox <alan@...ux.intel.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/