[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1349827466.26044.16@snotra>
Date: Tue, 9 Oct 2012 19:04:26 -0500
From: Scott Wood <scottwood@...escale.com>
To: Mitch Bradley <wmb@...mworks.com>
CC: Stephen Warren <swarren@...dotorg.org>,
Michal Marek <mmarek@...e.cz>,
Stephen Warren <swarren@...dia.com>,
<devicetree-discuss@...ts.ozlabs.org>,
<linux-kernel@...r.kernel.org>
Subject: Re: dtc: import latest upstream dtc
On 10/09/2012 06:20:53 PM, Mitch Bradley wrote:
> On 10/9/2012 11:16 AM, Stephen Warren wrote:
> > On 10/01/2012 12:39 PM, Jon Loeliger wrote:
> >>>
> >>> What more do you think needs discussion re: dtc+cpp?
> >>
> >> How not to abuse the ever-loving shit out of it? :-)
> >
> > Perhaps we can just handle this through the regular patch review
> > process; I think it may be difficult to define and agree upon
> exactly
> > what "abuse" means ahead of time, but it's probably going to be easy
> > enough to recognize it when one sees it?
>
>
> One of the ways it could get out of hand would be via "include
> dependency hell". People will be tempted to reuse existing .h files
> containing pin definitions, which, if history is a guide, will end up
> depending on all sorts of other .h files.
>
> Another problem I often face with symbolic names is the difficulty of
> figuring out what the numerical values really are (for debugging),
> especially when .h files are in different subtrees from the files that
> use the definitions, and when they use multiple macro levels and fancy
> features like concatenation. Sometimes I think it's clearer just to
> write the number and use a comment to say what it is.
Both comments apply just as well to ordinary C code, and I don't think
anyone would seriously suggest just using comments instead for C code.
Is there a way to ask CPP to evaluate a macro in the context of the
input file, rather than produce normal output? If not, I guess you
could make a tool that creates a wrapper file that includes the main
file and then evaluates the symbol you want.
-Scott
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists