linux-kernel - Re: [PATCH v2] fix stack memory content leak via UNAME26

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGXu5jJFN3CRVH6=39PVKw4QJXaGt7NRu-UO7u5xCKv+nxi6+w@mail.gmail.com>
Date:	Wed, 10 Oct 2012 17:39:23 -0700
From:	Kees Cook <keescook@...omium.org>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Andi Kleen <ak@...ux.intel.com>,
	PaX Team <pageexec@...email.hu>
Subject: Re: [PATCH v2] fix stack memory content leak via UNAME26

On Wed, Oct 10, 2012 at 4:44 PM, Andrew Morton
<akpm@...ux-foundation.org> wrote:
> On Wed, 10 Oct 2012 16:36:44 -0700
> Kees Cook <keescook@...omium.org> wrote:
>
>> > would suffice?
>> >
>> > Not a big deal I guess, but copying out stuff beyond the NUL is a bit odd.
>>
>> Sure, that looks good to me.
>
> I think I'll stick with your tested patch for now.  Could you please
> add "clean that up" to your todo list?

Sure. I've sent a v3 now. It still needed to handle the (theoretical)
len == 0 case, though.

-Kees

-- 
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/