lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 10 Oct 2012 20:06:11 -0700 From: Joe Perches <joe@...ches.com> To: Christopher Heiny <Cheiny@...aptics.com> Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>, Jean Delvare <khali@...ux-fr.org>, Linux Kernel <linux-kernel@...r.kernel.org>, Linux Input <linux-input@...r.kernel.org>, Allie Xiong <axiong@...aptics.com>, Vivian Ly <vly@...aptics.com>, Daniel Rosenberg <daniel.rosenberg@...aptics.com>, Joerie de Gram <j.de.gram@...il.com>, Wolfram Sang <w.sang@...gutronix.de>, Mathieu Poirier <mathieu.poirier@...aro.org>, Linus Walleij <linus.walleij@...ricsson.com>, Naveen Kumar Gaddipati <naveen.gaddipati@...ricsson.com>, Alexandra Chin <alexandra.chin@...synaptics.com> Subject: Re: [RFC PATCH 02/06] input/rmi4: Core files On Thu, 2012-10-11 at 02:49 +0000, Christopher Heiny wrote: > Joe Perches wrote: [] > > > + list_for_each_entry(entry, &data->rmi_functions.list, list) > > > + if (entry->irq_mask) > > > + process_one_interrupt(entry, irq_status, > > > + data); > > > > style nit, it'd be nicer with braces. > > I agree with you, but checkpatch.pl doesn't. :-( Sure it does. $ cat t.c { list_for_each_entry(entry, &data->rmi_functions.list, list) { if (entry->irq_mask) process_one_interrupt(entry, irq_status, data); } } $ ./scripts/checkpatch.pl --strict -f t.c total: 0 errors, 0 warnings, 0 checks, 7 lines checked t.c has no obvious style problems and is ready for submission. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists