linux-kernel - Re: [PATCH 5/6] ARM: ux500: Enable SDI4 port on the u9540 when booting with Device Tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121011072824.GQ9707@gmail.com>
Date:	Thu, 11 Oct 2012 08:28:24 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com>
Cc:	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linus.walleij@...ricsson.com, arnd@...db.de
Subject: Re: [PATCH 5/6] ARM: ux500: Enable SDI4 port on the u9540 when
 booting with Device Tree

On Wed, 10 Oct 2012, Jean-Christophe PLAGNIOL-VILLARD wrote:

> On 16:18 Wed 10 Oct     , Lee Jones wrote:
> > Here we add the device node for the SDI4 (MMC) port to the u9540
> > Device Tree source file. This will allow successful probing of
> > the internal MMC storage device when booting with DT enabled.
> > 
> > Acked-by: Linus Walleij <linus.walleij@...aro.org>
> > Signed-off-by: Lee Jones <lee.jones@...aro.org>
> > ---
> >  arch/arm/boot/dts/u9540.dts |   12 +++++++++++-
> >  1 file changed, 11 insertions(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/boot/dts/u9540.dts b/arch/arm/boot/dts/u9540.dts
> > index 28efe20..2dade76 100644
> > --- a/arch/arm/boot/dts/u9540.dts
> > +++ b/arch/arm/boot/dts/u9540.dts
> > @@ -21,7 +21,6 @@
> >  	};
> >  
> >  	soc-u9500 {
> > -
> why?

My OCD shining though. It's either this or I create a seperate patch
for it. I think sneaking it in here is better.

> >  		uart@...20000 {
> >  			status = "okay";
> >  		};
> > @@ -33,5 +32,16 @@
> >  		uart@...07000 {
> >  			status = "okay";
> >  		};
> > +
> > +		// On-board eMMC
> no c++ comment

Single line comments are perfectly valid in DTS(I) files.

See: Documentation/devicetree/booting-without-of.txt

> > +		sdi4_per2@...14000 {
> > +			arm,primecell-periphid = <0x10480180>;
> > +		        max-frequency = <50000000>;
> > +			bus-width = <8>;
> > +			mmc-cap-mmc-highspeed;
> > +			vmmc-supply = <&ab8500_ldo_aux2_reg>;
> you need add the pinctrl here

Pinctrl will come in time. We have a priority list.

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/