linux-kernel - Re: [PATCH -next] staging: dgrp: Add missing #include <linux/uaccess.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 11 Oct 2012 14:40:30 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Bill Pemberton <wfp5p@...ginia.edu>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	linux-next@...r.kernel.org,
	Geert Uytterhoeven <geert@...ux-m68k.org>
Subject: Re: [PATCH -next] staging: dgrp: Add missing #include <linux/uaccess.h>

On Thu, Sep 27, 2012 at 8:38 PM, Geert Uytterhoeven
<geert@...ux-m68k.org> wrote:
> On m68k:

Now also in mainline, cfr.
http://kisskb.ellerman.id.au/kisskb/buildresult/7344531/

> drivers/staging/dgrp/dgrp_mon_ops.c: In function ‘dgrp_mon_read’:
> drivers/staging/dgrp/dgrp_mon_ops.c:304: error: implicit declaration of function ‘copy_to_user’
> drivers/staging/dgrp/dgrp_specproc.c: In function ‘config_proc_write’:
> drivers/staging/dgrp/dgrp_specproc.c:470: error: implicit declaration of function ‘copy_from_user’
> drivers/staging/dgrp/dgrp_tty.c: In function ‘drp_wmove’:
> drivers/staging/dgrp/dgrp_tty.c:1284: error: implicit declaration of function ‘copy_from_user’
> drivers/staging/dgrp/dgrp_tty.c: In function ‘get_modem_info’:
> drivers/staging/dgrp/dgrp_tty.c:2267: error: implicit declaration of function ‘put_user’
> drivers/staging/dgrp/dgrp_tty.c: In function ‘set_modem_info’:
> drivers/staging/dgrp/dgrp_tty.c:2283: error: implicit declaration of function ‘access_ok’
> drivers/staging/dgrp/dgrp_tty.c:2283: error: ‘VERIFY_READ’ undeclared (first use in this function)
> drivers/staging/dgrp/dgrp_tty.c:2283: error: (Each undeclared identifier is reported only once
> drivers/staging/dgrp/dgrp_tty.c:2283: error: for each function it appears in.)
> drivers/staging/dgrp/dgrp_tty.c:2287: error: implicit declaration of function ‘get_user’
> drivers/staging/dgrp/dgrp_tty.c: In function ‘dgrp_tty_digigetedelay’:
> drivers/staging/dgrp/dgrp_tty.c:2474: error: implicit declaration of function ‘copy_to_user’
> drivers/staging/dgrp/dgrp_tty.c: In function ‘dgrp_tty_ioctl’:
> drivers/staging/dgrp/dgrp_tty.c:2618: error: ‘VERIFY_WRITE’ undeclared (first use in this function)
>
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> ---
> See also http://kisskb.ellerman.id.au/kisskb/buildresult/7277002/
>
>  drivers/staging/dgrp/dgrp_mon_ops.c  |    1 +
>  drivers/staging/dgrp/dgrp_specproc.c |    1 +
>  drivers/staging/dgrp/dgrp_tty.c      |    1 +
>  3 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/staging/dgrp/dgrp_mon_ops.c b/drivers/staging/dgrp/dgrp_mon_ops.c
> index 268dcb9..4792d05 100644
> --- a/drivers/staging/dgrp/dgrp_mon_ops.c
> +++ b/drivers/staging/dgrp/dgrp_mon_ops.c
> @@ -38,6 +38,7 @@
>  #include <linux/sched.h>
>  #include <asm/unaligned.h>
>  #include <linux/proc_fs.h>
> +#include <linux/uaccess.h>
>
>  #include "dgrp_common.h"
>
> diff --git a/drivers/staging/dgrp/dgrp_specproc.c b/drivers/staging/dgrp/dgrp_specproc.c
> index 28f5c9a..a5840e7 100644
> --- a/drivers/staging/dgrp/dgrp_specproc.c
> +++ b/drivers/staging/dgrp/dgrp_specproc.c
> @@ -39,6 +39,7 @@
>  #include <linux/proc_fs.h>
>  #include <linux/ctype.h>
>  #include <linux/seq_file.h>
> +#include <linux/uaccess.h>
>  #include <linux/vmalloc.h>
>
>  #include "dgrp_common.h"
> diff --git a/drivers/staging/dgrp/dgrp_tty.c b/drivers/staging/dgrp/dgrp_tty.c
> index 7d7de87..72f6fcf 100644
> --- a/drivers/staging/dgrp/dgrp_tty.c
> +++ b/drivers/staging/dgrp/dgrp_tty.c
> @@ -40,6 +40,7 @@
>  #include <linux/tty.h>
>  #include <linux/tty_flip.h>
>  #include <linux/sched.h>
> +#include <linux/uaccess.h>
>
>  #include "dgrp_common.h"
>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/