linux-kernel - Re: [PATCH 5/5] efivarfs: efivarfs_fill_super() ensure we clean up correctly on error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5076D1EC.1060100@canonical.com>
Date:	Thu, 11 Oct 2012 22:04:28 +0800
From:	Jeremy Kerr <jeremy.kerr@...onical.com>
To:	Andy Whitcroft <apw@...onical.com>
CC:	Matthew Garrett <mjg@...hat.com>,
	Matt Fleming <matt.fleming@...el.com>,
	linux-efi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/5] efivarfs: efivarfs_fill_super() ensure we clean up
 correctly on error

Hi Andy,

> @@ -969,16 +970,18 @@
>   		return -ENOMEM;
>
>   	list_for_each_entry_safe(entry, n, &efivars->list, list) {
> -		struct inode *inode;
>   		struct dentry *dentry, *root = efivarfs_sb->s_root;
> -		char *name;
>   		unsigned long size = 0;
>   		int len, i;
>
> +		inode = NULL;
> +
>   		len = utf16_strlen(entry->var.VariableName);
>
>   		/* GUID plus trailing NULL */
>   		name = kmalloc(len + 38, GFP_ATOMIC);
> +		if (!name)
> +			goto fail;
>
>   		for (i = 0; i < len; i++)
>   			name[i] = entry->var.VariableName[i] & 0xFF;
> @@ -991,7 +994,13 @@
>
>   		inode = efivarfs_get_inode(efivarfs_sb, root->d_inode,
>   					  S_IFREG | 0644, 0);
> +		if (!inode)
> +			goto fail_name;
> +			
>   		dentry = d_alloc_name(root, name);
> +		if (!dentry)
> +			goto fail_inode;
> +
>   		/* copied by the above to local storage in the dentry. */
>   		kfree(name);

If we break out of the loop on the second (and onwards) iteration, won't 
we still have the other inodes and dentries remaining allocated?

Cheers,


Jeremy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/