linux-kernel - Re: [PATCH 4/6] udf: remove un-needed variable from inode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20121011181150.GE18391@quack.suse.cz>
Date:	Thu, 11 Oct 2012 20:11:50 +0200
From:	Jan Kara <jack@...e.cz>
To:	Namjae Jeon <linkinjeon@...il.com>
Cc:	jack@...e.cz, linux-kernel@...r.kernel.org,
	Namjae Jeon <namjae.jeon@...sung.com>,
	Ashish Sangwan <a.sangwan@...sung.com>
Subject: Re: [PATCH 4/6] udf: remove un-needed variable from inode_getblk

On Wed 10-10-12 00:09:44, Namjae Jeon wrote:
> From: Namjae Jeon <namjae.jeon@...sung.com>
> 
> The variable last_block is not needed.
> 
> Signed-off-by: Namjae Jeon <namjae.jeon@...sung.com>
> Signed-off-by: Ashish Sangwan <a.sangwan@...sung.com>
  Thanks. I've merged the patch.

						Honza
> ---
>  fs/udf/inode.c |    3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/fs/udf/inode.c b/fs/udf/inode.c
> index 76a1f57..6fd9dc5 100644
> --- a/fs/udf/inode.c
> +++ b/fs/udf/inode.c
> @@ -587,7 +587,6 @@ out:
>  static sector_t inode_getblk(struct inode *inode, sector_t block,
>  			     int *err, int *new)
>  {
> -	static sector_t last_block;
>  	struct kernel_long_ad laarr[EXTENT_MERGE_SIZE];
>  	struct extent_position prev_epos, cur_epos, next_epos;
>  	int count = 0, startnum = 0, endnum = 0;
> @@ -677,7 +676,6 @@ static sector_t inode_getblk(struct inode *inode, sector_t block,
>  		return newblock;
>  	}
>  
> -	last_block = block;
>  	/* Are we beyond EOF? */
>  	if (etype == -1) {
>  		int ret;
> @@ -719,7 +717,6 @@ static sector_t inode_getblk(struct inode *inode, sector_t block,
>  			memset(&laarr[c].extLocation, 0x00,
>  				sizeof(struct kernel_lb_addr));
>  			count++;
> -			endnum++;
>  		}
>  		endnum = c + 1;
>  		lastblock = 1;
> -- 
> 1.7.9.5
> 
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/