lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <1349982438-2062-1-git-send-email-j.glisse@gmail.com>
Date:	Thu, 11 Oct 2012 15:07:18 -0400
From:	j.glisse@...il.com
To:	linux-kernel@...r.kernel.org
Cc:	roland@...hat.com, Jerome Glisse <jglisse@...hat.com>
Subject: [PATCH] coredump: always kill the task no matter what

From: Jerome Glisse <jglisse@...hat.com>

If do_coredump fails for any reason make sure that the task
is actualy wakeup and properly kill otherwise we endup with
zombies task.

Signed-off-by: Jerome Glisse <jglisse@...hat.com>
---
 fs/coredump.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/coredump.c b/fs/coredump.c
index fd37fac..4b61468 100644
--- a/fs/coredump.c
+++ b/fs/coredump.c
@@ -643,11 +643,11 @@ fail_dropcount:
 fail_unlock:
 	kfree(cn.corename);
 fail_corename:
-	coredump_finish(mm);
 	revert_creds(old_cred);
 fail_creds:
 	put_cred(cred);
 fail:
+	coredump_finish(mm);
 	return;
 }
 
-- 
1.7.12.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ