linux-kernel - Re: [ 103/133] xtensa: Add missing RCU idle APIs on idle loop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <507611ED.3050202@zankel.net>
Date:	Wed, 10 Oct 2012 17:25:17 -0700
From:	Chris Zankel <chris@...kel.net>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	alan@...rguk.ukuu.org.uk,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Josh Triplett <josh@...htriplett.org>
Subject: Re: [ 103/133] xtensa: Add missing RCU idle APIs on idle loop

Hi Greg,
Thanks for adding it.

Signed-off-by: Chris Zankel <chris@...kel.net>



On 10/10/2012 03:52 PM, Greg Kroah-Hartman wrote:
> 3.5-stable review patch.  If anyone has any objections, please let me know.
>
> ------------------
>
> From: Frederic Weisbecker <fweisbec@...il.com>
>
> commit 11ad47a0edbd62bfc0547cfcdf227a911433f207 upstream.
>
> In the old times, the whole idle task was considered
> as an RCU quiescent state. But as RCU became more and
> more successful overtime, some RCU read side critical
> section have been added even in the code of some
> architectures idle tasks, for tracing for example.
>
> So nowadays, rcu_idle_enter() and rcu_idle_exit() must
> be called by the architecture to tell RCU about the part
> in the idle loop that doesn't make use of rcu read side
> critical sections, typically the part that puts the CPU
> in low power mode.
>
> This is necessary for RCU to find the quiescent states in
> idle in order to complete grace periods.
>
> Add this missing pair of calls in the xtensa's idle loop.
>
> Reported-by: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>
> Signed-off-by: Frederic Weisbecker <fweisbec@...il.com>
> Cc: Chris Zankel <chris@...kel.net>
> Signed-off-by: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>
> Reviewed-by: Josh Triplett <josh@...htriplett.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>
> ---
>   arch/xtensa/kernel/process.c |    3 +++
>   1 file changed, 3 insertions(+)
>
> --- a/arch/xtensa/kernel/process.c
> +++ b/arch/xtensa/kernel/process.c
> @@ -31,6 +31,7 @@
>   #include <linux/mqueue.h>
>   #include <linux/fs.h>
>   #include <linux/slab.h>
> +#include <linux/rcupdate.h>
>   
>   #include <asm/pgtable.h>
>   #include <asm/uaccess.h>
> @@ -110,8 +111,10 @@ void cpu_idle(void)
>   
>   	/* endless idle loop with no priority at all */
>   	while (1) {
> +		rcu_idle_enter();
>   		while (!need_resched())
>   			platform_idle();
> +		rcu_idle_exit();
>   		schedule_preempt_disabled();
>   	}
>   }
>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/