linux-kernel - Re: [PATCH] block: Remove deadlock in disk_clear

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <50784CD3.2040008@kernel.dk>
Date:	Fri, 12 Oct 2012 11:01:07 -0600
From:	Jens Axboe <axboe@...nel.dk>
To:	Derek Basehore <dbasehore@...omium.org>
CC:	msb@...omium.org, spang@...omium.org, bfreed@...omium.org,
	arscott@...omium.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] block: Remove deadlock in disk_clear_events

On 2012-10-11 15:52, Derek Basehore wrote:
> In disk_clear_events, do not put work on system_nrt_freezable_wq. Instead, put
> it on system_nrt_wq.
> 
> There is a race between probing a usb and suspending the device. Since probing a
> usb calls disk_clear_events, which puts work on a frozen workqueue, probing
> cannot finish after the workqueue is frozen. However, suspending cannot finish
> until the usb probe is finished, so we get a deadlock.

Thanks, applied to later inclusion into 3.7. You did not mark this as
stable, though it seems it should be?

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/