linux-kernel - Re: [PATCH -stable] amd_iommu: attach device fails on the last pci device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1350062918.2112.53.camel@bling.home>
Date:	Fri, 12 Oct 2012 11:28:38 -0600
From:	Alex Williamson <alex.williamson@...hat.com>
To:	shuah.khan@...com
Cc:	joerg.roedel@....com, tglx@...utronix.de, mingo@...hat.com,
	hpa@...or.com, Greg KH <gregkh@...uxfoundation.org>,
	iommu@...ts.linux-foundation.org, x86@...nel.org,
	LKML <linux-kernel@...r.kernel.org>, stable@...r.kernel.org,
	shuahkhan@...il.com
Subject: Re: [PATCH -stable] amd_iommu: attach device fails on the last pci
 device

On Fri, 2012-10-12 at 10:29 -0600, Shuah Khan wrote:
> amd_iommu_attach_device() checks if device id is within the limits
> of amd_iommu_last_bdf and instead checking if devid > amd_iommu_last_bdf,
> it checks devid >= amd_iommu_last_bdf. As a result the last device attach
> fails because amd_iommu_attach_device() returns an -EINVAL.
> 
> This bug is in linux-2.6.32 and an equivalent fix in linux-2.6.33 and has been
> carried forward to later kernels and is in the upstream kernel. This equivalent
> fix includes restructuring and consolidating device checks into a routine
> check_device(). Instead of back-porting all of that work, spot-fixed the bug in
> amd_iommu_attach_device() for linux-2.6.32.
> 
> Signed-off-by: Shuah Khan <shuah.khan@...com>
> CC: <stable@...r.kernel.org> v2.6.32
> ---
>  arch/x86/kernel/amd_iommu.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kernel/amd_iommu.c b/arch/x86/kernel/amd_iommu.c
> index 3a44b75..67de7d7 100644
> --- a/arch/x86/kernel/amd_iommu.c
> +++ b/arch/x86/kernel/amd_iommu.c
> @@ -2288,7 +2288,7 @@ static int amd_iommu_attach_device(struct iommu_domain *dom,
>  
>  	devid = calc_devid(pdev->bus->number, pdev->devfn);
>  
> -	if (devid >= amd_iommu_last_bdf ||
> +	if (devid > amd_iommu_last_bdf ||
>  			devid != amd_iommu_alias_table[devid])
>  		return -EINVAL;
>  

Looks correct to me, this case was clearly inconsistent with other users
of amd_iommu_last_bdf.

Reviewed-by: Alex Williamson <alex.williamson@...hat.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/