linux-kernel - Re: [PATCH -stable] amd_iommu: attach device fails on the last pci device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1350067490.4627.8.camel@lorien2>
Date:	Fri, 12 Oct 2012 12:44:50 -0600
From:	Shuah Khan <shuah.khan@...com>
To:	Jonathan Nieder <jrnieder@...il.com>
Cc:	joerg.roedel@....com, tglx@...utronix.de, mingo@...hat.com,
	hpa@...or.com, Greg KH <gregkh@...uxfoundation.org>,
	iommu@...ts.linux-foundation.org, stable@...r.kernel.org,
	x86@...nel.org, LKML <linux-kernel@...r.kernel.org>,
	shuahkhan@...il.com
Subject: Re: [PATCH -stable] amd_iommu: attach device fails on the last pci
 device

On Fri, 2012-10-12 at 11:38 -0700, Jonathan Nieder wrote:
> Shuah Khan wrote:
> 
> > This bug is in linux-2.6.32 and an equivalent fix in linux-2.6.33 and has been
> > carried forward to later kernels and is in the upstream kernel. This equivalent
> > fix includes restructuring and consolidating device checks into a routine
> > check_device(). Instead of back-porting all of that work, spot-fixed the bug in
> > amd_iommu_attach_device() for linux-2.6.32.
> 
> To save Willy time: am I correct in guessing the upstream commit you
> are referring to is 98fc5a693bbdda498a556654c70d1e31a186c988
> (x86/amd-iommu: Use get_device_id and check_device where appropriate,
> 2009-11-24)?

Yes that is one. I looked that up again and it has the change to
amd_iommu_attach_device() to use check_device() and removes the check 

-	if (devid >= amd_iommu_last_bdf ||
-			devid != amd_iommu_alias_table[devid])
-		return -EINVAL;
+	devid = get_device_id(dev);

Ref: http://www.spinics.net/lists/linux-tip-commits/msg06129.html


Thanks,
-- Shuah


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/