linux-kernel - Re: [PATCH 2/4] acpi,memory-hotplug : rename remove_memory() to offline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHGf_=qr=Qsa==X=pZifu=C1n=dwt7_Hz+AR+-oqoFT2LqRzqA@mail.gmail.com>
Date:	Fri, 12 Oct 2012 14:57:26 -0400
From:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
To:	Wen Congyang <wency@...fujitsu.com>
Cc:	Yasuaki Ishimatsu <isimatu.yasuaki@...fujitsu.com>, x86@...nel.org,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	linux-acpi@...r.kernel.org, rientjes@...gle.com, liuj97@...il.com,
	len.brown@...el.com, cl@...ux.com, minchan.kim@...il.com,
	akpm@...ux-foundation.org
Subject: Re: [PATCH 2/4] acpi,memory-hotplug : rename remove_memory() to offline_memory()

On Mon, Oct 8, 2012 at 2:45 AM, Wen Congyang <wency@...fujitsu.com> wrote:
> At 10/05/2012 05:31 AM, KOSAKI Motohiro Wrote:
>> On Wed, Oct 3, 2012 at 6:02 AM, Yasuaki Ishimatsu
>> <isimatu.yasuaki@...fujitsu.com> wrote:
>>> From: Yasuaki Ishimatsu <isimatu.yasuaki@...fujitsu.com>
>>>
>>> add_memory() hot adds a physical memory. But remove_memory does not
>>> hot remove a phsical memory. It only offlines memory. The name
>>> confuse us.
>>>
>>> So the patch renames remove_memory() to offline_memory(). We will
>>> use rename_memory() for hot removing memory.
>>>
>>> CC: David Rientjes <rientjes@...gle.com>
>>> CC: Jiang Liu <liuj97@...il.com>
>>> CC: Len Brown <len.brown@...el.com>
>>> CC: Christoph Lameter <cl@...ux.com>
>>> Cc: Minchan Kim <minchan.kim@...il.com>
>>> CC: Andrew Morton <akpm@...ux-foundation.org>
>>> CC: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
>>> Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@...fujitsu.com>
>>> Signed-off-by: Wen Congyang <wency@...fujitsu.com>
>>> ---
>>>  drivers/acpi/acpi_memhotplug.c |    2 +-
>>>  include/linux/memory_hotplug.h |    2 +-
>>>  mm/memory_hotplug.c            |    6 +++---
>>>  3 files changed, 5 insertions(+), 5 deletions(-)
>>
>> Probably, the better way is to just remove remove_memory() and use
>> offline_pages().
>
> we don't notify the userspace that the memory is offlined in offline_pages().
> We reimplement offline_memory(), but ishimatsu doesn't include that patch to
> this series.

Quote from Documentation/SubmittingPatch

> 3) Separate your changes.
> Separate _logical changes_ into a single patch file.

Please send us _logical_ meaningful patch set.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/