linux-kernel - Re: [ 011/120] lib/gcd.c: prevent possible div by 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121012211600.GA24427@kroah.com>
Date:	Sat, 13 Oct 2012 06:16:00 +0900
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Ben Hutchings <ben@...adent.org.uk>
Cc:	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	alan@...rguk.ukuu.org.uk, Davidlohr Bueso <dave@....org>,
	Eric Dumazet <eric.dumazet@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [ 011/120] lib/gcd.c: prevent possible div by 0

On Fri, Oct 12, 2012 at 10:11:24PM +0100, Ben Hutchings wrote:
> On Thu, 2012-10-11 at 09:59 +0900, Greg Kroah-Hartman wrote:
> > 3.4-stable review patch.  If anyone has any objections, please let me know.
> > 
> > ------------------
> > 
> > From: Davidlohr Bueso <dave@....org>
> > 
> > commit e96875677fb2b7cb739c5d7769824dff7260d31d upstream.
> > 
> > Account for all properties when a and/or b are 0:
> > gcd(0, 0) = 0
> > gcd(a, 0) = a
> > gcd(0, b) = b
> > 
> > Fixes no known problems in current kernels.
> [...]
> 
> I can't believe this change is harmful, but unless there are some known
> problems this doesn't meet the criteria for a stable update.

It was discussed in the original thread of this patch that it would be a
good idea to have this in the stable releases, and I agree.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/