linux-kernel - Re: [PATCH] regmap : make lock/unlock functions customizable.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121012062607.GN11726@opensource.wolfsonmicro.com>
Date:	Fri, 12 Oct 2012 15:26:09 +0900
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	ciminaghi@...dd.com
Cc:	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regmap : make lock/unlock functions customizable.

On Mon, Oct 01, 2012 at 11:31:04PM +0200, ciminaghi@...dd.com wrote:
> From: Davide Ciminaghi <ciminaghi@...dd.com>
> 
> It is sometimes convenient for a regmap user to override the standard
> regmap lock/unlock functions with custom functions.

This looks good overall but...

> -static void regmap_lock_mutex(struct regmap *map)
> +static void regmap_lock_mutex(void *__map)
>  {
> +	struct regmap *map = (struct regmap *)__map;
>  	mutex_lock(&map->mutex);

...you should never need to cast away from or to void, if you do there's
a bug somewhere.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/