linux-kernel - Re: [PATCH 01/22] ufs: drop vmtruncate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20121013161706.GA19899@infradead.org>
Date:	Sat, 13 Oct 2012 12:17:06 -0400
From:	Christoph Hellwig <hch@...radead.org>
To:	Marco Stornelli <marco.stornelli@...il.com>
Cc:	Al Viro <viro@...IV.linux.org.uk>,
	Evgeniy Dushistov <dushistov@...l.ru>,
	linux-kernel@...r.kernel.org,
	Linux FS Devel <linux-fsdevel@...r.kernel.org>
Subject: Re: [PATCH 01/22] ufs: drop vmtruncate

> @@ -536,8 +536,9 @@ static int ufs_write_begin(struct file *file, struct address_space *mapping,
>  				ufs_getfrag_block);
>  	if (unlikely(ret)) {
>  		loff_t isize = mapping->host->i_size;
> -		if (pos + len > isize)
> -			vmtruncate(mapping->host, isize);
> +		if ((pos + len > isize) &&
> +			inode_newsize_ok(mapping->host, isize) == 0)
> +			truncate_setsize(mapping->host, isize);

write_begin always truncates down, so there should be no call to
inode_newsize_ok here.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/