linux-kernel - Re: [PULL] modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 14 Oct 2012 13:53:36 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Rusty Russell <rusty@...tcorp.com.au>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Alex Lyashkov <umka@...udlinux.com>,
	Arnd Bergmann <arnd@...db.com>,
	Dan Carpenter <dan.carpenter@...cle.com>,
	David Howells <dhowells@...hat.com>,
	"David S. Miller" <davem@...emloft.net>,
	Dmitry Kasatkin <dmitry.kasatkin@...el.com>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	Josh Boyer <jwboyer@...hat.com>, linux-crypto@...r.kernel.org,
	Lucas De Marchi <lucas.demarchi@...fusion.mobi>,
	Matthew Garrett <mjg59@...f.ucam.org>,
	Milan Broz <mbroz@...hat.com>,
	Ralf Baechle <ralf@...ux-mips.org>,
	Randy Dunlap <rdunlap@...otime.net>,
	Sam Ravnborg <sam@...nborg.org>
Subject: Re: [PULL] modules

On Sun, Oct 14, 2012 at 1:11 PM, Linus Torvalds
<torvalds@...ux-foundation.org> wrote:
>
> I've pulled and resolved the branch, and I'm going through it now, but
> I'd like this verified before I push out if it all looks fine..

Hmm. So this thing makes me wonder:

        /* Not having a signature is only an error if we're strict. */
        if (err < 0 && fips_enabled)
                panic("Module verification failed with error %d in FIPS mode\n",
                      err);

do we really want to panic (even in fips_enabled mode)?

Sounds like it will just kill the machine if we ever end up having an
unsigned module by mistake anywhere.

I realize that fips_enabled is only for crazy people, but it's exactly
code like this that limits it to only crazy people. Is there some
*reason* for this?

                 Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/