linux-kernel - Re: [PATCH] Drivers: Staging: CSR: made corrections on the indentation errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20121014112652.GA542@kroah.com>
Date:	Sun, 14 Oct 2012 04:26:52 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Sangho Yi <antiroot@...il.com>
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Drivers: Staging: CSR: made corrections on the
 indentation errors

On Sun, Oct 14, 2012 at 08:20:11PM +0900, Sangho Yi wrote:
> Originally there were a lot mis-indentation, so I made changes to use
> only the tabs (no spaces) on indenting code.
> - Still, the typedef struct ... tells warning message on checkpatch.pl.

Yes, we shouldn't be using a typedef, but why did you change the typedef
itself:

> -typedef struct
> -{
> -    u32 sec;
> -    u16 msec;
> +typedef struct _CsrTimeUtc {
> +	u32 sec;
> +	u16 msec;
>  } CsrTimeUtc;

Why add the _CsrTimeUtc here?  That's not really needed, right?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/